Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect ROP USD Render output directories #190

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

lucaseck
Copy link
Contributor

@lucaseck lucaseck commented Nov 1, 2024

Fixes: #191

What was the problem/requirement? (What/Why)

  • Output directories were not being detected from USD Render ROPs
  • The output override field was not being taken into account when detecting USD Render output directories
  • Output directories were not being detected from specified LOP Paths in the USD Render nodes

What was the solution? (How)

  • Add a new handler for USD Render nodes(both LOP and ROP USD Render nodes)
  • Add logic for taking the override output path if one is provided in the nodes
  • Add logic for taking the specified LOP Path node as the node to detect output directories from if one is provided
  • Fixed an additional bug where we weren't checking that a USD Prim was invalid(doesn't exist) or not

What is the impact of this change?

More output directory detection cases are handled

How was this change tested?

Manually tested by creating a scene with both a ROP USD Render node and a LOP USD Render node. Verified all of the cases for overrides, LOP Paths, regular inputs to the nodes worked for detecting the output directories.

  • Have you run the unit tests?
    Unit tests passed

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucaseck lucaseck force-pushed the detect_rop_usd_outputs branch 2 times, most recently from e850600 to 6996b13 Compare November 1, 2024 20:36
Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
@lucaseck lucaseck force-pushed the detect_rop_usd_outputs branch from 6996b13 to 0fdc92b Compare November 4, 2024 15:46
Copy link

sonarqubecloud bot commented Nov 4, 2024

@lucaseck lucaseck marked this pull request as ready for review November 4, 2024 15:52
@lucaseck lucaseck requested a review from a team as a code owner November 4, 2024 15:52
@lucaseck lucaseck merged commit fbeb81d into aws-deadline:mainline Nov 6, 2024
18 checks passed
@lucaseck lucaseck deleted the detect_rop_usd_outputs branch November 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: USD Render ROP Output Directories Are Not Detected
3 participants