-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fail when mantra license error is seen #164
Conversation
|
80af643
to
05ebe2a
Compare
05ebe2a
to
4d1febd
Compare
completed_regexes = [re.compile(".*Finished Rendering.*")] | ||
progress_regexes = [re.compile(".*ALF_PROGRESS ([0-9]+)%.*")] | ||
error_regexes = [re.compile(".*Error: .*|.*\\[Error\\].*", re.IGNORECASE)] | ||
license_regexes = [ | ||
# generic runtime error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be under the license error regex list if it's a generic error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth on this a few times. It was previously just a license error, so I'm not changing functionality here.
Putting it with the generic errors would then make the "strict error handling" apply to it which I'm not sure we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
shutil_usage = shutil.disk_usage(os.getcwd()) | ||
self._exc_info = RuntimeError( | ||
f"{match.group(0)}\n" | ||
"This error is typically associated with a licensing error" | ||
" when using Houdini. Check your licensing configuration.\n" | ||
f"Free disc space: {shutil_usage.free//1024//1024}M\n" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why did we report the free disk space when we suspected license errors before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was due to copy/pasting some hyper-specific maya license handling. They erroneously report licensing errors on the cloud by saying they ran out of disk space. So we did a few attempts at improving it to ensure that the user could easily verify that was not the case.
Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
4d1febd
to
298b5ec
Compare
What was the problem/requirement? (What/Why)
Houdini jobs weren't failing properly if a license error occurred when launching hython:
What was the solution? (How)
capture the license error and fail the job
What is the impact of this change?
Jobs properly fail!
How was this change tested?
Ran hython locally without a license connection and added a unit test
Was this change documented?
N/A
Is this a breaking change?
Nope
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.