fix: add missing submission telemetry event #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
previously approved these changes
May 27, 2024
|
Nice! Should we also be adding one for exceptions raised in submission? ie. lines 674-678 Would look something like: https://github.com/aws-deadline/deadline-cloud/blob/041550c40002e3a2d1b77a77530318212cf10b5d/src/deadline/client/ui/dialogs/submit_job_to_deadline_dialog.py#L487-L492 |
Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
lucaseck
force-pushed
the
submission_telemetry
branch
from
0c9431a to
03fb525
Compare
|
marofke
approved these changes
May 27, 2024
epmog
approved these changes
May 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Missing a telemetry event for submissions
What was the solution? (How)
Add the event
What is the impact of this change?
No more missing telemetry
How was this change tested?
Ran a submission and saw the event record
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.