feat!: run simulations sequentially #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowecawcaw
force-pushed
the
sim
branch
2 times, most recently
from
5144b3b to
37e2347
Compare
crowecawcaw
changed the title
epmog
reviewed
May 17, 2024
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
|
Regardless of if openjd-adaptor-runtime keeps the interface version, we can delay the decision by bumping it regardless. |
epmog
previously approved these changes
May 17, 2024
crowecawcaw
force-pushed
the
sim
branch
2 times, most recently
from
a223488 to
fc97c73
Compare
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
epmog
reviewed
May 21, 2024
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
lucaseck
reviewed
May 22, 2024
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Joel Wong <127782171+joel-wong-aws@users.noreply.github.com> Signed-off-by: Stephen Crowe <crowest@amazon.com>
…ing (aws-deadline#154) Signed-off-by: Joel Wong <127782171+joel-wong-aws@users.noreply.github.com> Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com> Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
ddneilson
reviewed
May 23, 2024
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
joel-wong-aws
previously approved these changes
May 23, 2024
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
joel-wong-aws
previously approved these changes
May 23, 2024
| try: | ||
| connected_node = rop_steps[-1] | ||
| except IndexError: | ||
| return [] |
There was a problem hiding this comment.
nit: it would be better to raise an exception here (otherwise an exception will be raised down the chain), but based on the current code, this statement is actually unreachable, so not blocking
…ni/submitter.py Co-authored-by: Morgan Epp <60796713+epmog@users.noreply.github.com> Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
|
epmog
approved these changes
May 24, 2024
joel-wong-aws
approved these changes
May 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The submitter previously always rendered each frame as a task, and tasks would be distributed to different Deadline Cloud workers. But some node types like simulations must be run sequentially - each frame depends on the previous one.
What was the solution? (How)
Introduce a new sequential rendering strategy where all frames are rendered inside a single Deadline Cloud task which ensures they are sequentially on a single worker.
Specific changes include:
What is the impact of this change?
Simulations are run efficiently.
How was this change tested?
I submitted a hip file with simulations and regular rendering. The simulations resulted in single tasks and the renders resulted in 1 task per frame.
Was this change documented?
No, but it needs to be.
Is this a breaking change?
No. Changing the runData schema could have been a breaking change, but I took care to ensure the old
frameparameter is still handled correctly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.