fix: output directory detection #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
epmog
previously approved these changes
May 6, 2024
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
lucaseck
force-pushed
the
fix_output_directory_detection
branch
2 times, most recently
from
e137aea to
c59f9a8
Compare
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/assets.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/assets.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/assets.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/assets.py
Outdated
Show resolved
Hide resolved
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/assets.py
Outdated
Show resolved
Hide resolved
epmog
reviewed
May 7, 2024
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Show resolved
Hide resolved
lucaseck
force-pushed
the
fix_output_directory_detection
branch
from
febc490 to
9372a2f
Compare
Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
lucaseck
force-pushed
the
fix_output_directory_detection
branch
from
9372a2f to
354c3ca
Compare
joel-wong-aws
approved these changes
May 7, 2024
epmog
approved these changes
May 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Fixes #138
Many types of nodes were not being included in the output directory detection when using parse files.
What was the solution? (How)
assets.pyfile.What is the impact of this change?
Hopefully a majority of cases should now be covered by the output directory detection
How was this change tested?
Created a scene file with all of the newly added node types within. Clicked
Parse Filesand verified that the directories specified in each nodes output paths were included. For testing the Fetch and Wedge nodes I made longer chains with valid output nodes at the end of the chains to ensure they were recursively being checked until finding the end node.Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.