Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass through log verbosity #141

Merged
merged 1 commit into from
May 7, 2024

Conversation

joel-wong-aws
Copy link
Contributor

@joel-wong-aws joel-wong-aws commented May 2, 2024

Resolves #120

What was the problem/requirement? (What/Why)

The logging verbosity for Mantra and Karma renders can be configured through the Mantra or Karma node and this is passed through to the Deadline Cloud render.

What was the solution? (How)

Currently, this value is hardcoded to 3. Removing this code passes through the log verbosity specified in the Mantra or Karma node.

Also noted that Karma was incorrectly labeled as having a node type "Driver/karma" rather than "Driver/usdrender", so updated that everywhere.

What is the impact of this change?

Log verbosity can be specified in Deadline Cloud renders, and progress is output by default in Karma for easier tracking.

How was this change tested?

  1. Created a simple scene with geometry, light, and camera
  2. Created a Mantra node and Deadline Cloud node, connected the Mantra node output to the Deadline Cloud node input
  3. Adjusted the Mantra log verbosity under Rendering > Statistics >Verbose Level
  4. Submitted renders with different verbosity levels and confirmed that verbosity of logs changed accordingly
  5. Created a Karma node and unlocked it
  6. Introspected into the Karma node and adjusted the USD Render node > Husk > Statistics > Verbosity
  7. Submitted renders with different verbosity levels and confirmed that verbosity of logs changed accordingly

Was this change documented?

No, not required

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@joel-wong-aws joel-wong-aws requested a review from a team as a code owner May 2, 2024 21:55
@epmog
Copy link
Contributor

epmog commented May 2, 2024

Looks like some tests are failing too, so whatever the changes ends up being, we'll have to update them as well.

@joel-wong-aws joel-wong-aws changed the title fix: pass through log verbosity wip: fix: pass through log verbosity May 4, 2024
@joel-wong-aws joel-wong-aws changed the title wip: fix: pass through log verbosity fix: pass through log verbosity May 6, 2024
@joel-wong-aws joel-wong-aws changed the title fix: pass through log verbosity wip: fix: pass through log verbosity May 6, 2024
@joel-wong-aws joel-wong-aws force-pushed the log_verbosity branch 3 times, most recently from 08c40ec to 5df0714 Compare May 6, 2024 19:46
@joel-wong-aws joel-wong-aws changed the title wip: fix: pass through log verbosity fix: pass through log verbosity May 6, 2024
Signed-off-by: Joel Wong <127782171+joel-wong-aws@users.noreply.github.com>
@joel-wong-aws joel-wong-aws merged commit 24ff283 into aws-deadline:mainline May 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: logging verbosity is always set to level 3
3 participants