fix: verify Deadline Cloud render node input exists before submitting #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epmog
approved these changes
May 1, 2024
Signed-off-by: Joel Wong <127782171+joel-wong-aws@users.noreply.github.com>
epmog
force-pushed
the
wonjoel/verify_input_rop
branch
from
4413175 to
a047c89
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
If the Deadline Cloud ROP does not have an input ROP, then submission of a job will first hash and upload all the files for the job, then attempt to submit the job, then get a confusing error message related to missing steps.
What was the solution? (How)
The error is caused by missing an input ROP, but the the message is confusing. Added verification that there is an input ROP at the start of the submission.
What is the impact of this change?
Easier onboarding for customers
How was this change tested?
Before:
After:
Was this change documented?
No, not necessary
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.