Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle directories, references, and unnecessary files #132

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

crowecawcaw
Copy link
Contributor

What was the problem/requirement? (What/Why)

There were several related bugs with automatically detecting and attaching files:

What was the solution? (How)

When detecting if a parameter is a path or file, evaluate the parameter first to resolve the references and attach the expanded path. Also ignore op: data references which are not files.

What is the impact of this change?

Directories are detected. References in file and directory names are handled correctly. Data references are ignored.

How was this change tested?

Expanded unit tests. For manual testing, I created a file cache inside a geometry node and pointed the file cache to directories both with $HIP as part of the path and without it. I then opened the Deadline Cloud node and clicked "Parse files". The files and directories were correctly detected and attached.

Was this change documented?

No documentation needed.

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@crowecawcaw crowecawcaw requested a review from a team as a code owner April 26, 2024 03:23
Copy link
Contributor

@lucaseck lucaseck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributions. I've left some minor comments.

As well, for #122 this won't fully fix it since I don't see anything about those header files being ignored. If that's going to be a separate PR no worries. Just didn't want to have the issue be closed without all parts being fixed.

Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
@crowecawcaw crowecawcaw merged commit 0a909b3 into aws-deadline:mainline Apr 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants