fix: improve error message for expired credentials #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-wong-aws
force-pushed
the
expired_credentials_message
branch
from
8c994b6 to
d46b27b
Compare
chocecil
reviewed
Apr 25, 2024
| print('AWS Deadline Cloud credentials are expired. Please open the Deadline Cloud Monitor and login.') |
There was a problem hiding this comment.
Nice spotting! Updated!
joel-wong-aws
force-pushed
the
expired_credentials_message
branch
from
d46b27b to
5bd33bf
Compare
chocecil
previously approved these changes
Apr 25, 2024
joel-wong-aws
force-pushed
the
expired_credentials_message
branch
from
5bd33bf to
94a6ca7
Compare
chocecil
previously approved these changes
Apr 25, 2024
joel-wong-aws
force-pushed
the
expired_credentials_message
branch
from
94a6ca7 to
8b9a73e
Compare
lucaseck
reviewed
Apr 26, 2024
src/deadline/houdini_submitter/otls/deadline_cloud.hda/Driver_1deadline__cloud/OnCreated
Outdated
Show resolved
Hide resolved
joel-wong-aws
force-pushed
the
expired_credentials_message
branch
from
8b9a73e to
e8322a6
Compare
lucaseck
approved these changes
Apr 29, 2024
chocecil
approved these changes
Apr 29, 2024
"Expired credentials" -> "AWS Deadline Cloud credentials are expired." Signed-off-by: Joel Wong <127782171+joel-wong-aws@users.noreply.github.com>
joel-wong-aws
force-pushed
the
expired_credentials_message
branch
from
e8322a6 to
93efd46
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When I first used the Deadline Cloud ROP, an error popped up in the Houdini console with the message "Expired credentials". It wasn't clear what this was referring to and how to resolve it.
What was the solution? (How)
Added more detail to the message to indicate that this was referring to Deadline Cloud credentials and added instructions about how to resolve the issue.
What is the impact of this change?
Easier debugging and clearer action items for customers with expired credentials.
How was this change tested?
Created a Deadline Cloud ROP in Houdini
/outnetwork without authenticating via the Deadline Cloud Monitor. The Houdini console popped up with a message. Previously, this message was "Expired credentials". Now, it is "AWS Deadline Cloud credentials are expired."Previous error message:
Updated error message:
Was this change documented?
No, not required
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.