Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safely handle potential deps when not submitting step deps #106

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

epmog
Copy link
Contributor

@epmog epmog commented Mar 30, 2024

What was the problem/requirement? (What/Why)

Submitting without step dependencies would fail if there were no dependency_names in the node. ie. if the node we were submitting didn't have any dependencies to render.

What was the solution? (How)

Do a safe delete of the dependency names, and at the same time, fix the name of the step to just be the ROP name instead of {ROP Name}-{render_order}.

What is the impact of this change?

More workflows work

How was this change tested?

hatch run fmt
hatch build
hatch run lint
hatch run test
hatch shell
hatch run install

Launched Houdini and was able to submit jobs that contained nodes with and without deps, when "submit step deps" was not enabled.

Was this change documented?

N/A

Is this a breaking change?

Nope

Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
@epmog epmog requested a review from a team as a code owner March 30, 2024 19:46
@marofke marofke merged commit 99f9285 into mainline Mar 30, 2024
9 checks passed
@marofke marofke deleted the safe_delete_deps branch March 30, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants