fix: safely handle potential deps when not submitting step deps #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Submitting without step dependencies would fail if there were no
dependency_names
in the node. ie. if the node we were submitting didn't have any dependencies to render.What was the solution? (How)
Do a safe delete of the dependency names, and at the same time, fix the name of the step to just be the ROP name instead of
{ROP Name}-{render_order}
.What is the impact of this change?
More workflows work
How was this change tested?
Launched Houdini and was able to submit jobs that contained nodes with and without deps, when "submit step deps" was not enabled.
Was this change documented?
N/A
Is this a breaking change?
Nope