-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: output directory and output file prefix are remembered when submitting the same scene #188
Merged
moorec-aws
merged 2 commits into
aws-deadline:mainline
from
moorec-aws:moorec/make_output_sticky
Feb 13, 2025
Merged
feat: output directory and output file prefix are remembered when submitting the same scene #188
moorec-aws
merged 2 commits into
aws-deadline:mainline
from
moorec-aws:moorec/make_output_sticky
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com>
a9d5519
to
1e8b9fb
Compare
|
AWS-Samuel
approved these changes
Feb 12, 2025
justinsaws
approved these changes
Feb 12, 2025
Merged
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
This was referenced Mar 7, 2025
This was referenced Mar 17, 2025
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Issue reported that the Output Directory and Output File Prefix fields in the blender submitter has to be set every time the submitter is opened.
What was the solution? (How)
set
output_path
andoutput_file_prefix
to sticky.What is the impact of this change?
After the output directory and output file prefix have been set, they will be remembered the next time the submitter is opened for that same scene
How was this change tested?
hatch run lint && hatch run test && hatch run integ:test
output_####
.output_####
Please run the integration tests and paste the results below
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.