Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output directory and output file prefix are remembered when submitting the same scene #188

Merged

Conversation

moorec-aws
Copy link
Contributor

@moorec-aws moorec-aws commented Feb 11, 2025

What was the problem/requirement? (What/Why)

Issue reported that the Output Directory and Output File Prefix fields in the blender submitter has to be set every time the submitter is opened.

outputs

What was the solution? (How)

set output_path and output_file_prefix to sticky.

What is the impact of this change?

After the output directory and output file prefix have been set, they will be remembered the next time the submitter is opened for that same scene

How was this change tested?

hatch run lint && hatch run test && hatch run integ:test

  1. Opened a new scene in the submitter, confirmed the Output Directory was set to "/tmp" and the Output File Prefix is set to output_####.
  2. Change the the Output Directory and Output File Prefix and Submitted a Job.
  3. Confirmed that when the Submitter was re-opened in the same scene the settings from Step 2 were still set.
  4. Confirmed when opening a new scene that Output Directory was set to "/tmp" and the Output File Prefix is set to output_####

Please run the integration tests and paste the results below

hatch run integ:test
=========================================================================================================== test session starts ===========================================================================================================
platform darwin -- Python 3.11.11, pytest-8.3.4, pluggy-1.5.0 -- /Users/moorec/Library/Application Support/hatch/env/virtual/deadline-cloud-for-blender/UAESGOCP/integ/bin/python
cachedir: .pytest_cache
rootdir: /Users/moorec/Demo/deadline-cloud-for-blender
configfile: pyproject.toml
plugins: cov-6.0.0, xdist-3.6.1
1 worker [2 items]     
scheduling tests via LoadScheduling

test/integ/test_blender.py::test_minimal_scene_submitter 
[gw0] [ 50%] PASSED test/integ/test_blender.py::test_minimal_scene_submitter 
test/integ/test_blender.py::test_minimal_scene_adaptor 
[gw0] [100%] XFAIL test/integ/test_blender.py::test_minimal_scene_adaptor 

=========================================================================================================== slowest 5 durations ===========================================================================================================
32.94s call     test/integ/test_blender.py::test_minimal_scene_adaptor
5.30s call     test/integ/test_blender.py::test_minimal_scene_submitter
0.00s setup    test/integ/test_blender.py::test_minimal_scene_submitter
0.00s setup    test/integ/test_blender.py::test_minimal_scene_adaptor
0.00s teardown test/integ/test_blender.py::test_minimal_scene_adaptor
====================================================================================================== 1 passed, 1 xfailed in 35.53s ======================================================================================================

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@moorec-aws moorec-aws changed the title chore!: set output_path and output_file_prefix fields to sticky chore: set output_path and output_file_prefix fields to sticky Feb 12, 2025
Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com>
@moorec-aws moorec-aws force-pushed the moorec/make_output_sticky branch from a9d5519 to 1e8b9fb Compare February 12, 2025 15:53
@moorec-aws moorec-aws marked this pull request as ready for review February 12, 2025 22:44
@moorec-aws moorec-aws requested a review from a team as a code owner February 12, 2025 22:44
@aws-deadline aws-deadline deleted a comment from justinsaws Feb 12, 2025
@moorec-aws moorec-aws merged commit 1db21c6 into aws-deadline:mainline Feb 13, 2025
19 checks passed
@moorec-aws moorec-aws deleted the moorec/make_output_sticky branch February 13, 2025 17:53
@epmog epmog changed the title chore: set output_path and output_file_prefix fields to sticky feat: output directory and output file prefix is remembered when submitting the same scene Feb 13, 2025
@epmog epmog changed the title feat: output directory and output file prefix is remembered when submitting the same scene feat: output directory and output file prefix are remembered when submitting the same scene Feb 13, 2025
This was referenced Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants