feat(adaptor): Add BLENDER_EXECUTABLE environment variable #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epmog
changed the title
lucaseck
approved these changes
Dec 3, 2024
epmog
approved these changes
Dec 3, 2024
This allows us to dynamically point to the version of Blender that we want to render with. Signed-off-by: Alex Hughes <ahughesalex@gmail.com>
Signed-off-by: Alex Hughes <ahughesalex@gmail.com>
Ahuge
force-pushed
the
ah/feature/environment-variable-blender
branch
from
241bc72 to
969d6ca
Compare
|
Rebased off of mainline |
|
Merged
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
This was referenced Mar 7, 2025
This was referenced Mar 17, 2025
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The assumption that the blender executable exists on the PATH doesn't always make sense, often it is easier to specify the version of Blender to use by explicit path and using an environment variable is an easy way to do this for customers.
What was the solution? (How)
We have defined a new environment variable BLENDER_EXECUTABLE which follows the naming from
deadline-cloud-for-cinema-4dof<EXE_NAME>_EXECUTABLEWhat is the impact of this change?
Additional functionality, non-breaking, adds the environment variable override but falls back to existing functionality
How was this change tested?
Was this change documented?
Yes added in the README.md
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.