-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(adaptor): eevee render engine rename to BLENDER_EEVEE_NEXT for 4.2 #139
Merged
lucaseck
merged 1 commit into
aws-deadline:mainline
from
lucaseck:fix_render_name_eevee_42
Nov 5, 2024
Merged
fix(adaptor): eevee render engine rename to BLENDER_EEVEE_NEXT for 4.2 #139
lucaseck
merged 1 commit into
aws-deadline:mainline
from
lucaseck:fix_render_name_eevee_42
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
|
epmog
approved these changes
Nov 4, 2024
erico-aws
approved these changes
Nov 5, 2024
Merged
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
This was referenced Mar 7, 2025
This was referenced Mar 17, 2025
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The adaptor was failing for EEVEE jobs with 4.2 because of a rename to the render engine name. When trying to start an EEVEE render with 4.2 you would get an error like:
This rename was a breaking change in Blender 4.2
What was the solution? (How)
Use BLENDER_EEVEE_NEXT for Blender versions >= 4.2.0 instead of BLENDER_EEVEE which is kept for compatibility with older versions.
What is the impact of this change?
Blender adaptor works for EEVEE on 4.2
How was this change tested?
Using the adaptor override I ran submissions with 3.6 and 4.2 for eevee jobs and ensured both versions now worked and also did smoke tests with cycles for each version.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.