Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adaptor): eevee render engine rename to BLENDER_EEVEE_NEXT for 4.2 #139

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

lucaseck
Copy link
Contributor

@lucaseck lucaseck commented Nov 4, 2024

What was the problem/requirement? (What/Why)

The adaptor was failing for EEVEE jobs with 4.2 because of a rename to the render engine name. When trying to start an EEVEE render with 4.2 you would get an error like:

TypeError: bpy_struct: item.attr = val: enum "BLENDER_EEVEE" not found in ('BLENDER_EEVEE_NEXT', 'BLENDER_WORKBENCH', 'CYCLES')

This rename was a breaking change in Blender 4.2

What was the solution? (How)

Use BLENDER_EEVEE_NEXT for Blender versions >= 4.2.0 instead of BLENDER_EEVEE which is kept for compatibility with older versions.

What is the impact of this change?

Blender adaptor works for EEVEE on 4.2

How was this change tested?

Using the adaptor override I ran submissions with 3.6 and 4.2 for eevee jobs and ensured both versions now worked and also did smoke tests with cycles for each version.

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
@lucaseck lucaseck requested a review from a team as a code owner November 4, 2024 23:36
Copy link

sonarqubecloud bot commented Nov 4, 2024

@lucaseck lucaseck merged commit e848012 into aws-deadline:mainline Nov 5, 2024
18 checks passed
@lucaseck lucaseck deleted the fix_render_name_eevee_42 branch November 5, 2024 15:52
This was referenced Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants