fix: Enable close button on the submitter dialog in Blender 4.2 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Osiowy <134728121+erico-aws@users.noreply.github.com>
|
mwiebe
approved these changes
Oct 7, 2024
epmog
approved these changes
Oct 8, 2024
This was referenced Oct 11, 2024
Closed
Merged
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
This was referenced Mar 7, 2025
This was referenced Mar 17, 2025
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The submitter's close button was disabled in Blender 4.2. The only way to close the dialog was to either, Submit, Export Bundle or press escape.
What was the solution? (How)
Explicitly added the Qt
WindowCloseButtonHintto the dialog's window flags.Fixes #126
What is the impact of this change?
Slightly better experience on 4.2.
How was this change tested?
Manually added to both a 4.2 and 3.6 install. Both worked as expected.
Was this change documented?
No.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.