Skip to content

Remove premature subcomponent build in CompositeComponent geometry #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

gpeairs
Copy link
Member

@gpeairs gpeairs commented Jun 6, 2025

Previously calling geometry(cc::CompositeComponent) (e.g. in render! or autofill!) would build! the schematic of cc, replacing its components with CoordinateSystems. There's no reason for this to happen, and it prevents certain operations from working as expected after rendering the schematic (even though rendering shouldn't modify the schematic itself). An example is the use of a custom halo for a subcomponent—this was previously impossible without also defining a custom halo for the composite component that skipped the build! step, and even then the custom subcomponent halo could not be used after rendering. To demonstrate we add a custom halo for the star transmon island.

@gpeairs gpeairs force-pushed the gp/no-build-composite branch from e849d61 to 005ab48 Compare June 6, 2025 19:47
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@gpeairs gpeairs merged commit 5e998f2 into main Jun 6, 2025
6 checks passed
@gpeairs gpeairs deleted the gp/no-build-composite branch June 6, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant