Remove premature subcomponent build in CompositeComponent geometry #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously calling
geometry(cc::CompositeComponent)
(e.g. inrender!
orautofill!
) wouldbuild!
the schematic ofcc
, replacing its components withCoordinateSystem
s. There's no reason for this to happen, and it prevents certain operations from working as expected after rendering the schematic (even though rendering shouldn't modify the schematic itself). An example is the use of a custom halo for a subcomponent—this was previously impossible without also defining a custom halo for the composite component that skipped thebuild!
step, and even then the custom subcomponent halo could not be used after rendering. To demonstrate we add a custom halo for the star transmon island.