Adding Sagemaker pipeline sample #272
Conversation
ack-prow
bot
added
the
needs-ok-to-test
|
Hi @prayeole. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
samples/pipeline/README.md
Outdated
|
|
||
| ### Modify/Create a JSON pipeline definition | ||
|
|
||
| Create the JSON pipeline definition using the JSON schema documented at https://aws-sagemaker-mlops.github.io/sagemaker-model-building-pipeline-definition-JSON-schema/. You will need to convert your JSON pipeline definition into String format to pass to the *.spec.pipelineDefinition* key in the Kubernetes YAML spec. You may use online third-party tools to convert from JSON to String format. In this sample, you are provided a sample pipeline definition with one Training step. |
There was a problem hiding this comment.
It is possible to pass a json object as is using the yaml-multi-line directive. Something similar to https://github.com/aws-controllers-k8s/iam-controller/blob/main/test/e2e/resources/role_simple.yaml#L9-L21 .
However not sure if the sagemaker API accepts indented json strings
There was a problem hiding this comment.
Thanks @a-hilaly . I updated the pipeline spec with inline JSON object, however, still called out passing as string as another option in the README, because it may be easier especially, when the pipeline definition is large with multiple steps.
samples/pipeline/README.md
Outdated
|
|
||
| To list all pipelines created using the ACK controller use the following command: | ||
| ``` | ||
| $ kubectl get pipeline.sagemaker.services.k8s.aws | ||
| ``` | ||
| If it is a pipeline executions it is endpointsconfigs.sagemaker.services.k8s.aws | ||
| ``` | ||
| $ kubectl get pipelineexecution.sagemaker.services.k8s.aws | ||
| ``` |
There was a problem hiding this comment.
nit: you could also use short names such as pipeline and pipelineexecution
There was a problem hiding this comment.
Updated this as suggested.
There was a problem hiding this comment.
Nice thanks for the contribution! Lets see if @suryans-commit has any comments
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prayeole, ryansteakley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes: Adding a Sagemaker pipeline example for creating and executing a pipeline run.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.