Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Feb 2, 2023

Update to ACK runtime v0.23.0, code-generator v0.23.1



NOTE:
This PR increments the release version of service controller from v0.1.7 to v0.1.8

Once this PR is merged, release v0.1.8 will be automatically created for s3-controller

Please close this PR, if you do not want the new patch release for s3-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building s3-controller ====
Copying common custom resource definitions into s3
Building Kubernetes API objects for s3
Generating deepcopy code for s3
Generating custom resource definitions for s3
Building service controller for s3
Generating RBAC manifests for s3
Running gofmt against generated code for s3
Updating additional GitHub repository maintenance files
==== building s3-controller release artifacts ====
Building release artifacts for s3-v0.1.8
Generating common custom resource definitions
Generating custom resource definitions for s3
Generating RBAC manifests for s3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RedbackThomson
Copy link
Contributor

/test s3-release-test

@RedbackThomson
Copy link
Contributor

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023
@ack-prow
Copy link

ack-prow bot commented Feb 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Feb 2, 2023
@ack-prow ack-prow bot merged commit a8e28c4 into main Feb 2, 2023
@RedbackThomson RedbackThomson deleted the ack-bot/rt-v0.23.0-codegen-v0.23.1 branch February 2, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants