Add tests for deletion policy #91
Conversation
|
/hold |
ack-bot
added
the
do-not-merge/hold
RedbackThomson
force-pushed
the
deletion-policy-tests
branch
from
8f5cf2a to
ddb9927
Compare
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
|
/retest s3-release-test |
|
@RedbackThomson: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all |
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
I dig it. Nice work on this @RedbackThomson :)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Description of changes:
Adds a new set of e2e tests for the deletion policy.
@pytest.mark.parametrizesets up a matrix for all test combinations of namespace and resource annotations. The new test fixture creates a new namespace (with optional deletion policy annotation) and then creates a bucket (also with optional deletion policy namespace) into it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.