Skip to content

Conversation

@maddy-jo
Copy link
Contributor

@maddy-jo maddy-jo commented Sep 2, 2022

This PR resolves issue 1407 related to S3 accelerate error handling in govcloud accounts.

Co-authored-by: Madeline Lumetta madeline.lumetta@adhocteam.us
Co-authored-by: Giang Nguyen nguyen_giang@bah.com
Co-authored-by: Manali Bhatt bhatt_manali@bah.com

Issue #, if available: 1407

Description of changes: This PR adds a check for the AWS error code UnsupportedArgument in addPutFieldsToSpec in pkg/resource/bucket/hook.go and uses the default transfer accelerate configuration for the spec if that error is returned. The UnsupportedArgument error is not documented by the S3 docs but is returned by the S3 API in GovCloud regions for us and other GovCloud users, as we documented in this comment.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…govcloud accounts

Co-authored-by: Mike Lumetta <mike.lumetta@adhocteam.us>
Co-authored-by: Giang Nguyen <nguyen_giang@bah.com>
Co-authored-by: Manali Bhatt <bhatt_manali@bah.com>
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 2, 2022

Hi @mjlumetta. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2022
@a-hilaly
Copy link
Member

a-hilaly commented Sep 2, 2022

/ok-to-test

@ack-bot ack-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2022
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot folks! I'll merge right away since there isn't a simple way of testing this change using our current prow infrastructure.
/ok-to-test
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, mjlumetta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 921a26b into aws-controllers-k8s:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 ACK - Unsupported Argument

4 participants