Fix default canned ACL delta false positive #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
approved these changes
May 2, 2022
Contributor
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
Yep, this works. I'm curious whether you could add a unit test for this, but then again, I'm not sure we're going to keep this dual way of handling ACLs long-term, so... meh :)
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-controllers-k8s/community#1282
Description of changes:
The custom ACL code was giving a false positive on the delta when comparing an empty
Spec.ACLto the list of default ACL possibilities on a fresh bucket. This was causing the controller to always callSyncACL, throwing an error if the spec also defined properties which denied ACL use (such asObjectOwnership). This pull request checks for the case where theSpec.ACLis nil and where the bucket has the default grants, and will ignore the delta, preventing the false positive.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.