Skip to content

Conversation

@a-hilaly
Copy link
Member

Issue aws-controllers-k8s/community#799

Description of changes:

  • Add s3 Bucket e2e tests for create and delete operations

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@ack-bot
Copy link
Collaborator

ack-bot commented May 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes
Copy link
Contributor

/ok-to-test

@ack-bot ack-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 25, 2021
@a-hilaly
Copy link
Member Author

/test s3-pre-submit

@RedbackThomson
Copy link
Contributor

/test s3-pre-submit

@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@ack-bot ack-bot merged commit dcd8df2 into aws-controllers-k8s:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants