Skip to content

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented Aug 21, 2025

Issue #, if available:
v0.0.19 release of aws-controller-k8s/pkg fixes a bug where "URI" became "uRI" when used in CRD fields. Unfortunately, this bug made it into the s3-controller. Forcing the "uRI" in affected field to maintain existing behavior and avoid breaking change in the Bucket CRD.

Description of changes:

  • Apply go_tag in generator.yaml to force Logging.LoggingEnabled.TargetGrants.Grantee.URI field to "uRI" to avoid breaking change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Apply go_tag in generator.yaml to force      Logging.LoggingEnabled.TargetGrants.Grantee.URI field to "uRI" to avoid breaking change.
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler August 21, 2025 20:45
@ack-prow ack-prow bot added the approved label Aug 21, 2025
@knottnt
Copy link
Contributor Author

knottnt commented Aug 21, 2025

Note, this change is not expected to impact CRD or generated code. Should maintain all existing behavior.

@knottnt
Copy link
Contributor Author

knottnt commented Aug 21, 2025

/retest

@ack-prow
Copy link

ack-prow bot commented Aug 21, 2025

@knottnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-verify-attribution 8ca6537 link false /test s3-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2025
@ack-prow
Copy link

ack-prow bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit c806540 into aws-controllers-k8s:main Aug 25, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants