Skip to content

Add inline comments for deep copy patching #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ack-bot merged 1 commit into from
Jul 22, 2021
Merged

Add inline comments for deep copy patching #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/runtime/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,10 @@ func (r *resourceReconciler) patchResourceMetadataAndSpec(
}

rlog.Enter("kc.Patch (metadata + spec)")
// It is necessary to use `DeepCopyObject` versions of `latest` when calling
// `Patch` as this method overrides all values as merged from `desired`.
// This may affect `latest` in later execution, as otherwise this would set
//`desired` == `latest` after calling this method.
err = r.kc.Patch(
ctx,
latest.RuntimeObject().DeepCopyObject(),
Expand Down Expand Up @@ -373,6 +377,10 @@ func (r *resourceReconciler) patchResourceStatus(
return nil
}
rlog.Enter("kc.Patch (status)")
// It is necessary to use `DeepCopyObject` versions of `latest` when calling
// `Patch` as this method overrides all values as merged from `desired`.
// This may affect `latest` in later execution, as otherwise this would set
//`desired` == `latest` after calling this method.
err = r.kc.Status().Patch(
ctx,
latest.RuntimeObject().DeepCopyObject(),
Expand Down