Address Review Comments

Author: mbaijal

pkg/errors/error.go

@@ -49,9 +49,9 @@ var (
 	// after some wait time
 	TemporaryOutOfSync = fmt.Errorf(
 		"temporary out of sync, reconcile after some time")
-	// TemporaryOutOfSync is to indicate the error isn't really an error
+	// RequeueOnSuccess is to indicate the error isn't really an error
 	// but more of a marker that the status check will be performed
-	// after some wait time
+	// after some wait time after the specified duration
 	RequeueOnSuccess = fmt.Errorf(
 		"resource creation successful but reconcile after some time")
 	// Terminal is returned with resource is in Terminal Condition

pkg/requeue/requeue.go

@@ -21,11 +21,6 @@ const (
 	DefaultRequeueAfterDuration time.Duration = 30 * time.Second
 )
 
-// GetDurationInSeconds converts an integer into a time duration in seconds
-func GetDurationInSeconds(duration int) time.Duration {
-	return time.Duration(duration) * time.Second
-}
-
 // Needed returns a new RequeueNeeded to instruct the ACK runtime to requeue
 // the processing item without been logged as error.
 func Needed(err error) *RequeueNeeded {

pkg/runtime/reconciler.go

@@ -15,7 +15,8 @@ package runtime
 
 import (
 	"context"
-
+	"time"
+	
 	"github.com/go-logr/logr"
 	"github.com/pkg/errors"
 	corev1 "k8s.io/api/core/v1"
@@ -273,10 +274,10 @@ func (r *resourceReconciler) Sync(
 	for _, condition := range latest.Conditions() {
 		if condition.Type == ackv1alpha1.ConditionTypeResourceSynced {
 			if condition.Status == corev1.ConditionTrue {
-				duration, status := r.rmf.GetRequeueOnSuccessSeconds()
-				if status {
+				duration, isRequeueOnSuccess := r.rmf.GetRequeueOnSuccessSeconds()
+				if isRequeueOnSuccess {
 					return requeue.NeededAfter(
-						ackerr.RequeueOnSuccess, requeue.GetDurationInSeconds(duration))
+						ackerr.RequeueOnSuccess, (time.Duration(duration) * time.Second))
 				}
 			} else {
 				return requeue.NeededAfter(