Initial Commit: Infinite Requeue

Author: mbaijal

pkg/errors/error.go

@@ -49,6 +49,11 @@ var (
 	// after some wait time
 	TemporaryOutOfSync = fmt.Errorf(
 		"temporary out of sync, reconcile after some time")
+	// TemporaryOutOfSync is to indicate the error isn't really an error
+	// but more of a marker that the status check will be performed
+	// after some wait time
+	RequeueOnSuccess = fmt.Errorf(
+		"resource creation successful but reconcile after some time")
 	// Terminal is returned with resource is in Terminal Condition
 	Terminal = fmt.Errorf(
 		"resource is in terminal condition")

pkg/requeue/requeue.go

@@ -21,6 +21,11 @@ const (
 	DefaultRequeueAfterDuration time.Duration = 30 * time.Second
 )
 
+// GetDurationInSeconds converts an integer into a time duration in seconds
+func GetDurationInSeconds(duration int) time.Duration {
+	return time.Duration(duration) * time.Second
+}
+
 // Needed returns a new RequeueNeeded to instruct the ACK runtime to requeue
 // the processing item without been logged as error.
 func Needed(err error) *RequeueNeeded {

pkg/runtime/reconciler.go

@@ -271,10 +271,17 @@ func (r *resourceReconciler) Sync(
 		return err
 	}
 	for _, condition := range latest.Conditions() {
-		if condition.Type == ackv1alpha1.ConditionTypeResourceSynced &&
-			condition.Status != corev1.ConditionTrue {
-			return requeue.NeededAfter(
-				ackerr.TemporaryOutOfSync, requeue.DefaultRequeueAfterDuration)
+		if condition.Type == ackv1alpha1.ConditionTypeResourceSynced {
+			if condition.Status == corev1.ConditionTrue {
+				duration, status := r.rmf.GetRequeueOnSuccessSeconds()
+				if status {
+					return requeue.NeededAfter(
+						ackerr.RequeueOnSuccess, requeue.GetDurationInSeconds(duration))
+				}
+			} else {
+				return requeue.NeededAfter(
+					ackerr.TemporaryOutOfSync, requeue.DefaultRequeueAfterDuration)				
+			}
 		}
 	}
 	return nil

pkg/types/aws_resource_manager.go

@@ -89,4 +89,7 @@ type AWSResourceManagerFactory interface {
 	) (AWSResourceManager, error)
 	// IsAdoptable returns true if the resource is able to be adopted
 	IsAdoptable() bool
+	// GetRequeueOnSuccessSeconds returns true if the resource should be requeued after specified seconds
+	// Default is false which means resource will not be requeued after success.
+	GetRequeueOnSuccessSeconds() (int, bool)
 }