Skip to content

Update to ACK runtime v0.37.1, code-generator v0.37.0 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Aug 13, 2024

Update to ACK runtime v0.37.1, code-generator v0.37.0



NOTE:
This PR increments the release version of service controller from v0.0.8 to v0.0.9

Once this PR is merged, release v0.0.9 will be automatically created for networkfirewall-controller

Please close this PR, if you do not want the new patch release for networkfirewall-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building networkfirewall-controller ====
Copying common custom resource definitions into networkfirewall
Building Kubernetes API objects for networkfirewall
Generating deepcopy code for networkfirewall
Generating custom resource definitions for networkfirewall
Building service controller for networkfirewall
Generating RBAC manifests for networkfirewall
Running gofmt against generated code for networkfirewall
Updating additional GitHub repository maintenance files
==== building networkfirewall-controller release artifacts ====
Building release artifacts for networkfirewall-v0.0.9
Generating common custom resource definitions
Generating custom resource definitions for networkfirewall
Generating RBAC manifests for networkfirewall

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Aug 13, 2024
@ack-prow ack-prow bot requested a review from a-hilaly August 13, 2024 18:01
Copy link

ack-prow bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ack-prow bot commented Aug 30, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
networkfirewall-verify-attribution b06b371 link true /test networkfirewall-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly a-hilaly closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants