Skip to content

Adding e2e tests for ScalingConfig #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Adding e2e tests for ScalingConfig #76

merged 1 commit into from
Feb 6, 2023

Conversation

Vandita2020
Copy link
Member

Description of changes:
Adding e2e tests for ScalingConfig

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-bot ack-bot requested a review from a-hilaly January 31, 2023 00:13
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vandita2020
To complete the pull request process, please assign a-hilaly after the PR has been reviewed.
You can assign the PR to them by writing /assign @a-hilaly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot requested a review from vijtrip2 January 31, 2023 00:13
@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch from 32fd770 to 21c47d8 Compare January 31, 2023 00:19
@Vandita2020
Copy link
Member Author

/test all

1 similar comment
@Vandita2020
Copy link
Member Author

/test all

@ack-bot
Copy link
Collaborator

ack-bot commented Jan 31, 2023

@Vandita2020: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
lambda-release-test 21c47d8 link /test lambda-release-test
lambda-kind-e2e 21c47d8 link /test lambda-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

/test all

1 similar comment
@Vandita2020
Copy link
Member Author

/test all

@a-hilaly
Copy link
Member

/retest

@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch 3 times, most recently from d361088 to 0a83ef9 Compare February 1, 2023 00:58
@Vandita2020
Copy link
Member Author

/test all

@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch from 0a83ef9 to 91f8ccc Compare February 1, 2023 17:15
@Vandita2020
Copy link
Member Author

/test all

@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch from 91f8ccc to d9fd2d9 Compare February 1, 2023 18:44
@Vandita2020
Copy link
Member Author

/test all

@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch from d9fd2d9 to 6879760 Compare February 1, 2023 18:55
@Vandita2020
Copy link
Member Author

/test all

@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch from 6879760 to 9fec124 Compare February 1, 2023 19:14
@Vandita2020
Copy link
Member Author

/test all

@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch from 9fec124 to f6a9780 Compare February 1, 2023 19:24
@Vandita2020
Copy link
Member Author

/test all

@Vandita2020 Vandita2020 marked this pull request as ready for review February 1, 2023 20:41
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2023
@ack-prow ack-prow bot requested a review from RedbackThomson February 1, 2023 20:41
@Vandita2020 Vandita2020 force-pushed the scaling_config_e2e_tests branch from f6a9780 to 9022198 Compare February 3, 2023 18:18
a-hilaly
a-hilaly approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@ack-prow
Copy link

ack-prow bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, Vandita2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Feb 6, 2023
@ack-prow ack-prow bot merged commit da81ee2 into aws-controllers-k8s:main Feb 6, 2023
michaelhtm pushed a commit to rushmash91/lambda-controller that referenced this pull request Feb 5, 2025
@ack-bot
Update to ACK runtime v0.33.0, code-generator v0.33.0 (aws-contro…
1fd6a4d 
…llers-k8s#76)

### Update to ACK runtime `v0.33.0`, code-generator `v0.33.0`

----------

* ACK code-generator `v0.33.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.33.0)
* ACK runtime `v0.33.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.33.0)

----------

NOTE:
This PR increments the release version of service controller from `v0.0.32` to `v0.0.33`

Once this PR is merged, release `v0.0.33` will be automatically created for `mq-controller`

**Please close this PR, if you do not want the new patch release for `mq-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building mq-controller ====
Copying common custom resource definitions into mq
Building Kubernetes API objects for mq
Generating deepcopy code for mq
Generating custom resource definitions for mq
Building service controller for mq
Generating RBAC manifests for mq
Running gofmt against generated code for mq
Updating additional GitHub repository maintenance files
==== building mq-controller release artifacts ====
Building release artifacts for mq-v0.0.33
Generating common custom resource definitions
Generating custom resource definitions for mq
Generating RBAC manifests for mq
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vandita2020 @ack-bot @a-hilaly