Skip to content

Conversation

@rushmash91
Copy link
Member

Description of changes:

The AWS ElastiCache DescribeCacheClusters API requires the ShowCacheNodeInfo parameter to be explicitly set to true to return cache node details including endpoints. The ACK controller was calling this API without this parameter, resulting in responses that contained cluster metadata but omitted the node details like endpoints.

Added a direct modification to the sdkFind function in pkg/resource/cache_cluster/sdk.go to set ShowCacheNodeInfo = true on all DescribeCacheClusters API calls.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and knottnt August 22, 2025 21:18
@ack-prow ack-prow bot added the approved label Aug 22, 2025
@ack-prow
Copy link

ack-prow bot commented Aug 22, 2025

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution f91c8d0 link false /test elasticache-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91 rushmash91 changed the title add node details to status fix: set ShowCacheNodeInfo parameter to true for CacheClusters Aug 22, 2025
@rushmash91 rushmash91 requested review from a-hilaly and removed request for knottnt August 22, 2025 21:26
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! @rushmash91

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2025
@ack-prow
Copy link

ack-prow bot commented Aug 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit c373be4 into aws-controllers-k8s:main Aug 22, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants