Skip to content

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Aug 8, 2025

Issue #2565

Description of changes:

  • support NetworkType + IPDiscovery
  • add unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and knottnt August 8, 2025 21:33
@ack-prow ack-prow bot added the approved label Aug 8, 2025
@michaelhtm michaelhtm force-pushed the feat/addnetworktypeipdiscoverytoreplicationgroup branch from 3d34942 to c5b922f Compare August 8, 2025 22:38
@michaelhtm
Copy link
Member Author

/test elasticache-kind-e2e

@michaelhtm michaelhtm force-pushed the feat/addnetworktypeipdiscoverytoreplicationgroup branch from c5b922f to 33880b8 Compare August 12, 2025 17:29
@michaelhtm michaelhtm force-pushed the feat/addnetworktypeipdiscoverytoreplicationgroup branch from 33880b8 to 4670044 Compare August 12, 2025 21:26
@ack-prow
Copy link

ack-prow bot commented Aug 12, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution 4670044 link false /test elasticache-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm michaelhtm requested review from a-hilaly and rushmash91 and removed request for jlbutler August 12, 2025 23:24

NetworkType:
is_immutable: true
hooks:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: why does it need to be immutable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked it up..

@rushmash91
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
@ack-prow
Copy link

ack-prow bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 9b0f0e8 into aws-controllers-k8s:main Aug 12, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants