-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Add NetworkType + IPDiscovery to ReplicationGroup #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add NetworkType + IPDiscovery to ReplicationGroup #179
Conversation
3d34942 to
c5b922f
Compare
|
/test elasticache-kind-e2e |
c5b922f to
33880b8
Compare
add unit tests
33880b8 to
4670044
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| NetworkType: | ||
| is_immutable: true | ||
| hooks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: why does it need to be immutable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked it up..
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #2565
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.