Skip to content

Ignore TransitEncryptionEnabled in modify when unchanged #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
+11 −5
Merged

Ignore TransitEncryptionEnabled in modify when unchanged #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2025-06-11T00:03:37Z"
build_hash: e675923dfc54d8b6e09730098c3e3e1056d3c1e9
go_version: go1.24.3
version: v0.48.0
build_date: "2025-06-24T10:48:48Z"
build_hash: a488d4e8a9222ed51e5690cb5850beb21cce5a1f
go_version: go1.24.2
version: v0.48.0-1-ga488d4e
api_directory_checksum: e7d8480a655968a4f441db9509fd5561aa5eb1c4
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
Expand Down
3 changes: 3 additions & 0 deletions pkg/resource/replication_group/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion templates/hooks/replication_group/sdk_update_post_build_request.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
if !delta.DifferentAt("Spec.LogDeliveryConfigurations") {
input.LogDeliveryConfigurations = nil
}
if !delta.DifferentAt("Spec.TransitEncryptionEnabled") {
input.TransitEncryptionEnabled = nil
}
if delta.DifferentAt("UserGroupIDs") {
for _, diff := range delta.Differences {
if diff.Path.Contains("UserGroupIDs") {
Expand Down Expand Up @@ -54,4 +57,4 @@
}
}
}
}
}
Copy link
Member

@michaelhtm michaelhtm Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍