Skip to content

Conversation

@michaelhtm
Copy link
Member

Description of changes:
The To/FromACKTags function signatures are changing with the
next code-gen release. This PR aims to ensure custom code adapts as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 March 14, 2025 03:02
@ack-prow ack-prow bot added the approved label Mar 14, 2025
@michaelhtm michaelhtm force-pushed the update/acktagsconversion branch from 48eea6a to b7d890d Compare March 14, 2025 21:17
The To/FromACKTags function signatures are changing with the next
code-gen release. This PR aims to ensure custom code adapts as well.
@michaelhtm michaelhtm force-pushed the update/acktagsconversion branch from b7d890d to 24679d2 Compare March 28, 2025 17:41
@michaelhtm
Copy link
Member Author

/retest

1 similar comment
@michaelhtm
Copy link
Member Author

/retest

@ack-prow
Copy link

ack-prow bot commented Mar 28, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution 24679d2 link false /test elasticache-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@ack-prow
Copy link

ack-prow bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 686c8e2 into aws-controllers-k8s:main Mar 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants