Skip to content

Conversation

@a-hilaly
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@ack-prow ack-prow bot requested a review from nmvk June 28, 2024 23:50
@ack-prow ack-prow bot added the approved label Jun 28, 2024
@a-hilaly a-hilaly changed the title [wip] Normalize e2e tests Remove tests that are not using ACK's testing framework Jul 8, 2024
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
@a-hilaly a-hilaly changed the title Remove tests that are not using ACK's testing framework Remove duplicate tests that are not using ACK's testing framework Jul 8, 2024
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 8, 2024

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@ack-prow
Copy link

ack-prow bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit e87c139 into main Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants