Skip to content

Fix AdoptedResource functionality for SecurityGroups #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix AdoptedResource functionality for SecurityGroups #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2023-12-06T21:43:43Z"
build_hash: 892f29d00a4c4ad21a2fa32919921de18190979d
build_date: "2023-12-13T07:19:26Z"
build_hash: 3653329ceeb20015851b8776a6061a3fb0ec2935
go_version: go1.21.1
version: v0.27.1
api_directory_checksum: 6e2d850d97f2f72db31c9bef522eca4ab95b3fcd
version: v0.27.1-6-g3653329
api_directory_checksum: d452bf19bfd1496aacdc215bf7cc9ea86c55c122
api_version: v1alpha1
aws_sdk_go_version: v1.44.93
generator_config_info:
file_checksum: d10a62517f87bacf988184f8c454b90b42dee732
file_checksum: ff084526a7037be1c7d08e2c7e742ac0679abc5f
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,8 @@ resources:
template_path: hooks/security_group/sdk_create_post_set_output.go.tpl
sdk_read_many_post_set_output:
template_path: hooks/security_group/sdk_read_many_post_set_output.go.tpl
post_set_resource_identifiers:
template_path: hooks/security_group/post_set_resource_identifiers.go.tpl
update_operation:
custom_method_name: customUpdateSecurityGroup
NetworkAcl:
Expand Down
2 changes: 2 additions & 0 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,8 @@ resources:
template_path: hooks/security_group/sdk_create_post_set_output.go.tpl
sdk_read_many_post_set_output:
template_path: hooks/security_group/sdk_read_many_post_set_output.go.tpl
post_set_resource_identifiers:
template_path: hooks/security_group/post_set_resource_identifiers.go.tpl
update_operation:
custom_method_name: customUpdateSecurityGroup
NetworkAcl:
Expand Down
4 changes: 4 additions & 0 deletions pkg/resource/security_group/resource.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions templates/hooks/security_group/post_set_resource_identifiers.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
if name, ok := identifier.AdditionalKeys["name"]; ok {
r.ko.Spec.Name = &name
}