feat(VPCPeeringConnection): add support for custom resource and additional fields for Modify OP and auto-accepting

[marcdavoli]

Changes

This PR adds the vpcpeeringconnections custom resource via the standard code-generator output, but with a few custom additions:

• Adds the possibility to use an ACK VPC resource as a Reference for the fields spec.vpcRef (instead of spec.vpcId) and spec.peerVpcRef (instead of spec.peerVpcId).
• Adds the spec.accepterPeeringConnectionOptions and spec.requesterPeeringConnectionOptions fields, which come from the ModifyVpcPeeringConnectionOptions API call, to allow the use of the allowDnsResolutionFromRemoteVpc, AllowEgressFromLocalVpcToRemoteClassicLink and AllowEgressFromLocalClassicLinkToRemoteVpc sub-fields.
• Adds the spec.acceptRequest (boolean) which will allow the VPC Peering Connection Request to automatically switch from status pending-acceptance to active without manual intervention. (Inspired by Crossplane's implementation (Ref))
• Adds the field spec.routes.vpcPeeringConnectionRef to the Route Table CR

Note: In a separate PR, we add the fields spec.acceptVPCPeeringRequestsFromVPCID and spec.acceptVPCPeeringRequestsFromVPCRefs to the VPC CRD, to allow you to add a list of VPC's from which you'd like to automatically accept incoming VPC Peering requests from.

References

• Slack Thread
• Github Issue: Add VPCPeeringConnection support to ec2-controller community#1943

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @marcdavoli. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/ok-to-test

[marcdavoli]

Fixes the code-generator mapping of the sdkUpdate function to use ModifyVpcPeeringConnectionOptions (Ref) instead of UpdateVpcPeeringConnection (which doesn't exist)

[marcdavoli]

These two fields are used by the ModifyVpcPeeringConnectionOptions API call, not the CreateVpcPeeringConnection call, but are represented as being natively part of the ACK resource.

[marcdavoli]

This hook wires up 2 fields that exist in the resource's Spec to include them into the Update operation payload

• AccepterPeeringConnectionOptions
• RequesterPeeringConnectionOptions

[a-hilaly]

Allez, cette fois, c'est la bonne!
Mercy buckets!!
/lgtm
/approve

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, marcdavoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment