Errors with AdoptedResources for flowlog and securitygroup ec2 resources

[alan-j-byrne]

Describe the bug
The Adopted Resources reconciller errors out when trying to adopt flowlog.ec2.services.k8s.aws or securitygroup.ec2.services.k8s.aws resources.

Steps to reproduce
Flowlog:
spec.aws.nameOrID: fl-xxxx
spec.kubernetes.group: ec2.services.k8s.aws
spec.kubernetes.kind: FlowLog
"error": "FlowLog.ec2.services.k8s.aws "my-resource" is invalid: [spec.resourceID: Required value, spec.resourceType: Required value]"}

SecurityGroup:
spec.aws.nameOrID: sg-xxx
spec.kubernetes.group: ec2.services.k8s.aws
spec.kubernetes.kind: SecurityGroup
"error": "SecurityGroup.ec2.services.k8s.aws "my-resource" is invalid: spec.name: Required value"}

It appears in both cases, the adopted resources reconciller is trying to create invalid resources for flowlog and securitygroup.

Expected outcome
SecurityGroup and FlowLog kind resources should be automatically created by the adoptedresources reconciller.

Environment

• Kubernetes version v1.27.3
• Using EKS (yes/no), if so version? no
• AWS service targeted (S3, RDS, etc.), securitygroup.ec2 & flowlog.ec2

[nnbu]

/assign

[nnbu]

The error

"error": "FlowLog.ec2.services.k8s.aws "my-resource" is invalid: [spec.resourceID: Required value, spec.resourceType: Required value]"}

comes from following code
https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/adoption_reconciler.go#L157

I will identify a fix for this

[ack-bot]

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale