Skip to content

Conversation

@AdrienKuhn
Copy link
Contributor

@AdrienKuhn AdrienKuhn commented Aug 15, 2025

Description of changes:

This pull request enhances the Helm deployment template by allowing users to add custom labels to Kubernetes deployments through values in the Helm chart, similar to what has been done at the spec.template.labels level. This makes the deployment more flexible and customizable.

Helm template improvements:

  • Added support for injecting user-defined deployment labels from .Values.deployment.labels into the metadata section of the deployment.yaml.tpl template.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2025
@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 August 15, 2025 01:47
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2025
@ack-prow
Copy link

ack-prow bot commented Aug 15, 2025

Hi @AdrienKuhn. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdrienKuhn AdrienKuhn marked this pull request as ready for review August 15, 2025 01:53
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2025
@ack-prow ack-prow bot requested a review from knottnt August 15, 2025 01:53
@AdrienKuhn
Copy link
Contributor Author

Hello @knottnt,

Is there anything else required to start testing this change ?

Thank you !

@knottnt
Copy link
Contributor

knottnt commented Aug 20, 2025

@AdrienKuhn No! I'll get that started for you. Thanks for the PR!

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2025
@knottnt
Copy link
Contributor

knottnt commented Aug 20, 2025

/retest

1 similar comment
@AdrienKuhn
Copy link
Contributor Author

/retest

@AdrienKuhn
Copy link
Contributor Author

Hello @knottnt ,

Is anything required from me to make the tests pass ?

Thank you !

@knottnt
Copy link
Contributor

knottnt commented Sep 2, 2025

@AdrienKuhn it looks like this might just be a flaky test. Doesn't seem to be related to your changes.

@knottnt
Copy link
Contributor

knottnt commented Sep 2, 2025

/test ec2-controller-test

@AdrienKuhn
Copy link
Contributor Author

/test s3-olm-test

1 similar comment
@AdrienKuhn
Copy link
Contributor Author

/test s3-olm-test

Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdrienKuhn this lgtm

@ack-prow ack-prow bot added the approved label Sep 3, 2025
Copy link
Contributor

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@ack-prow
Copy link

ack-prow bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdrienKuhn, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rushmash91
Copy link
Member

/retest

1 similar comment
@knottnt
Copy link
Contributor

knottnt commented Sep 3, 2025

/retest

@ack-prow
Copy link

ack-prow bot commented Sep 3, 2025

@AdrienKuhn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution d3bd0d2 link false /test verify-attribution
s3-olm-test d3bd0d2 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor

knottnt commented Sep 4, 2025

/test lambda-controller-test

@ack-prow ack-prow bot merged commit 9e29f01 into aws-controllers-k8s:main Sep 4, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants