- 
                Notifications
    You must be signed in to change notification settings 
- Fork 226
fix: pass deployment.labels to deployment #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass deployment.labels to deployment #618
Conversation
| Hi @AdrienKuhn. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. | 
| Hello @knottnt, Is there anything else required to start testing this change ? Thank you ! | 
| @AdrienKuhn No! I'll get that started for you. Thanks for the PR! /ok-to-test | 
| /retest | 
    
      
        1 similar comment
      
    
  
    | /retest | 
| Hello @knottnt , Is anything required from me to make the tests pass ? Thank you ! | 
| @AdrienKuhn it looks like this might just be a flaky test. Doesn't seem to be related to your changes. | 
| /test ec2-controller-test | 
| /test s3-olm-test | 
    
      
        1 similar comment
      
    
  
    | /test s3-olm-test | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AdrienKuhn this lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AdrienKuhn, knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
| /retest | 
    
      
        1 similar comment
      
    
  
    | /retest | 
| @AdrienKuhn: The following tests failed, say  
 Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. | 
| /test lambda-controller-test | 
Description of changes:
This pull request enhances the Helm deployment template by allowing users to add custom labels to Kubernetes deployments through values in the Helm chart, similar to what has been done at the
spec.template.labelslevel. This makes the deployment more flexible and customizable.Helm template improvements:
.Values.deployment.labelsinto themetadatasection of thedeployment.yaml.tpltemplate.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.