fix(helm): indent of extra volumes

[blanchardma]

Issue #2583

Description of changes:

This PR addresses an issue encountered when rendering a Helm chart that includes additional volumes, such as an emptyDir. The change ensures with - that leading whitespace is trimmed and using nindent instead of indent prevents unwanted blank lines. The issue originates from the following pull request #608.

To manually validate the fix of this PR in a chart based on the code-generator follow the steps below:

# Pull and extract the ACM chart, which is based on the code-generator: 
$ helm pull oci://public.ecr.aws/aws-controllers-k8s/acm-chart --version 1.0.14 && tar -xzf acm-chart-1.0.14.tgz

# Apply the fix from this PR to the chart
$ sed -i '208s|.*|        {{- toYaml .Values.deployment.extraVolumes \| nindent 8 }}|' ./acm-chart/templates/deployment.yaml

# Render the chart and verify the output:
$ helm template ./acm-chart --set deployment.extraVolumes[0].name=test --set deployment.extraVolumes[0].emptyDir.sizeLimit=1Mi

# Expected output snippet:
...
      hostPID: false
      hostNetwork: false
      dnsPolicy: ClusterFirst
      volumes:
        - emptyDir:
            sizeLimit: 1Mi
          name: test

To reproduce the issue with the current version, refer to the steps outlined in the mentioned issue at top.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @blanchardma. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knottnt]

@blanchardma Thanks for the PR!

/ok-to-test

[knottnt]

/test eks-controller-test

[knottnt]

/test eks-controller-test

[ack-prow]

@blanchardma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
verify-attribution	d2f81bb	link	false	/test verify-attribution
s3-olm-test	d2f81bb	link	false	/test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[knottnt]

/test eks-controller-test

[knottnt]

/lgtm

@blanchardma Thanks for the contribution!

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blanchardma, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [knottnt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment