chore: increase git fetch default timeout to 180s
#607
Conversation
The timeout being 30 seconds was causing a timeout error. Moving forward we may want to make certain changes to make the fetch faster
|
/retest |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
| sdkRepoURLV2 = "https://github.com/aws/aws-sdk-go-v2" | ||
| defaultGitCloneTimeout = 180 * time.Second | ||
| defaultGitFetchTimeout = 30 * time.Second | ||
| defaultGitFetchTimeout = 180 * time.Second |
There was a problem hiding this comment.
This is just for fetching tags right? it is hard to believe that fetching tags can take more than 30seconds, are those are just refs in the .git folder?
There was a problem hiding this comment.
It is..aws-sdk-go-v2 has 885 tags to be fetched...maybe moving forward we can rethink this...
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow
bot
merged commit 3cc82a1
into
aws-controllers-k8s:main
3 participants
Description of changes:
The timeout being 30 seconds was causing a timeout error.
Moving forward we may want to make certain changes to make the fetch faster
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.