Allow zero and negative values for generated float32 bounds check

[knottnt]

Issue #, if available:

Description of changes:

• Update set_sdk.go setSDKForScalar() to allow zero and negative values for float32 in bounds check

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[michaelhtm]

Great catch @knottnt!
left a few nits

[a-hilaly]

love it, thank Trevor! 🚀

[knottnt]

/retest

[michaelhtm]

/lgtm
/hold

[a-hilaly]

👍
/lgtm

[knottnt]

@michaelhtm @a-hilaly

Example of the new output shown below. The new check is quite a bit larger. Assuming we want to prevent float64 values smaller than math.SmallestNonzeroFloat32 from being silently changed to zero we could reduce the size of the generated bounds check by adding a new function to the runtime package. Then in code-gen we simply call the new function.

if temperatureCopy0 > math.MaxFloat32 || temperatureCopy0 < -math.MaxFloat32 || (temperatureCopy0 < math.SmallestNonzeroFloat32 && !(temperatureCopy0 <= 0)) || (temperatureCopy0 > -math.SmallestNonzeroFloat32 && !(temperatureCopy0 >= 0)) {
	return nil, fmt.Errorf("error: field temperature is of type float32")
}

This is replacing the below check which does not allow zero or negative values.

if temperatureCopy0 > math.MaxFloat32 || temperatureCopy0 < math.SmallestNonzeroFloat32 {
	return nil, fmt.Errorf("error: field temperature is of type float32")
}

[knottnt]

Had to use a new file since the existing set_sdk_test.go has a circular dependency with the code package due to testutils.

[ack-prow]

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
verify-attribution	ed4695d	link	false	/test verify-attribution
s3-olm-test	ed4695d	link	false	/test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[knottnt]

/test ec2-controller-test

[knottnt]

/unhold

[a-hilaly]

👍

[a-hilaly]

/lgtm

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly,knottnt,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment