Skip to content

Add conditional check before setting attributes in SetSDKSetAttributes #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

a-hilaly
Copy link
Member

Add a conditional check in SetSDKSetAttributes to only call SetAttributes
when the attribute map is not empty. This prevents API validation errors
that occur when setting an empty attribute map.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from jlbutler October 11, 2024 23:15
@ack-prow ack-prow bot added the approved label Oct 11, 2024
Add a conditional check in SetSDKSetAttributes to only call SetAttributes
when the attribute map is not empty. This prevents API validation errors
that occur when setting an empty attribute map.
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 11, 2024

/retest
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link

ack-prow bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member Author

/retest

1 similar comment
@a-hilaly
Copy link
Member Author

/retest

@a-hilaly
Copy link
Member Author

/test eks-controller-test

Copy link

ack-prow bot commented Oct 12, 2024

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 5bdd3b9 link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member Author

/test eks-controller-test

@ack-prow ack-prow bot merged commit 846d41f into aws-controllers-k8s:main Oct 12, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants