Extend getAttributeFromPath search to status fields as well.
#512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, `getAttributeFromPath` searched for paths in spec fields only. And acted as a no-op when it comes to status fields. This patch extends the search to status fields as well, allowing us to configure nested fields in the status as well. This is gonna be used to configure ECS Cluster `Status.Attachments.Type` go tags (set `type` instead of `type_`) Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
|
Skipping CI for Draft Pull Request. |
ack-prow
bot
added
the
do-not-merge/work-in-progress
a-hilaly
changed the title
getAttributeFromPath search in status fields as well.getAttributeFromPath search to status fields as well.
ack-prow
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch,
getAttributeFromPathsearched for paths in specfields only. And acted as a no-op when it comes to status fields. This
patch extends the search to status fields as well, allowing us to
configure nested fields in the status as well.
This is gonna be used to configure ECS Cluster
Status.Attachments.Typego tags (set
typeinstead oftype_)Signed-off-by: Amine Hilaly hilalyamine@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.