fix required fields that are renamed #393
Conversation
A previous commit that used the `github.com/aws-controllers-k8s/pkg/names` package instead of the local `pkg/names` package changed the implementation of the `Field.IsRequired` method slightly by no longer referring to the `names.ModelOriginal` value. This ModelOriginal value was really just a hack from a while ago because we didn't have support for reverse-lookups of renamed fields to original Input/Output struct member names. This patch adds that reverse lookup and fixes the IsRequired method to properly look up the original struct member name in the Input shape's required list. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
ack-bot
added
the
needs-ok-to-test
|
Hi @jaypipes. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@a-hilaly @RedbackThomson @jljaco Please note the changes to comments are from |
There was a problem hiding this comment.
Looks good to me, I'll leave it to @a-hilaly or @RedbackThomson for final approval
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
A previous commit that used the
github.com/aws-controllers-k8s/pkg/namespackage instead of the localpkg/namespackage changed the implementation of theField.IsRequiredmethod slightly by no longer referring to thenames.ModelOriginalvalue. This ModelOriginal value was really just a hack from a while ago because we didn't have support for reverse-lookups of renamed fields to original Input/Output struct member names.This patch adds that reverse lookup and fixes the IsRequired method to properly look up the original struct member name in the Input shape's required list.
Signed-off-by: Jay Pipes jaypipes@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.