Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws-controllers-k8s/code-generator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.30.0
Choose a base ref
...
head repository: aws-controllers-k8s/code-generator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.31.0
Choose a head ref
  • 10 commits
  • 45 files changed
  • 2 contributors

Commits on Feb 15, 2024

  1. Experimental configurations to override controller names (#494)

    Since the early days of ACK, we've always relied on the `serviceID` to
    name the controller repositories. The way names, go modules, import
    paths, helm charts are named relied on this `serviceID`. Which was the
    main reason why some controllers had a bit of odd names, like
    `prometheusservice-controller` instead of `amp-controller`,
    `acmpca-controller` instead of `pca-controller`. This patch introduces
    experimental configurations that instructs the code generator to
    override the serviceID/servicePackageName when it comes to import
    paths/helm charts names etc...
    
    Related issue: aws-controllers-k8s/community#1411
    
    Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    a-hilaly authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d3ac622 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. update OLM's manifest/bases/csv generation to use ControllerName (#506

    )
    
    Issue #, if available:
    - Relates: aws-controllers-k8s/community#2019
    
    Description of changes:
    Recently `ControllerName` was introduced to allow controllers to have a custom, more user friendly name. This change caused the `/config/manifest/bases/<SPN>.yaml` to be written to disk incorrectly for controllers that use the new `ControllerName` value. This change switches the `/config/manifest/bases/<CN>.yaml` to be written to disk so that OLM file/package generation can complete successfully and all of the proper values injected into the final `/bundle`.
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    acornett21 authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    fd54e0f View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. updating release script logic for olm flow to use cache director (#507)

    Updating the logic in the OLM flow to use a the default cache directory.
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    acornett21 authored Feb 17, 2024
    Configuration menu
    Copy the full SHA
    f429bd9 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Simplify controllers local build system (#509)

    3 years ago we added a mechanism to build controllers using local module
    files for both `ack-generate`, controller binaries and container images.
    However, those turned out to be very complex to manage and more
    importantly to maintain... the only use case we've seen over the years
    is the need to build a controller using a local runtime repository...
    
    Now that we want to start running e2e tests against runtime
    repositories, we need a simplified way to build controller images using
    the local runtime repository, only!
    
    This patch removes all the never-used tooling around `go.local.mod` and
    keeps `local-build-controller-image` for prow testing purposes.
    
    Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    a-hilaly authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    71c40be View commit details
    Browse the repository at this point in the history
  2. [local builds] move instructions to copy code before go mod commands (#…

    …510)
    
    Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
    a-hilaly authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    ab21f45 View commit details
    Browse the repository at this point in the history
  3. [runtime builds] run go mod tidy before builds (#511)

    Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
    a-hilaly authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    9c8a01f View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configure liveness and readiness probes for controller deployments (#508

    )
    
    Part of aws-controllers-k8s/community#2012
    
    This patch enhances controller availability by introducing liveness and
    readiness probes. By configuring /healthz and /readyz endpoints for all
    the controllers, the deployments can now effectively monitor their
    health status.
    
    While it's still a simple ping/pong healthz endpoints. We're laying the
    ground for future more complex healthz and readiness checks. Thinking
    something like checking that the CARM informer health...
    
    Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    a-hilaly authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ea8ce2d View commit details
    Browse the repository at this point in the history
  2. Pin github.com/aws-controllers-k8s/pkg to v0.0.10 (#513)

    Bringing `ACM` and `PCA` initialisms
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    a-hilaly authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f096213 View commit details
    Browse the repository at this point in the history
  3. Extend getAttributeFromPath search to status fields as well. (#512)

    Prior to this patch, `getAttributeFromPath` searched for paths in spec
    fields only. And acted as a no-op when it comes to status fields. This
    patch extends the search to status fields as well, allowing us to
    configure nested fields in the status as well.
    
    This is gonna be used to configure ECS Cluster `Status.Attachments.Type`
    go tags (set `type` instead of `type_`)
    
    Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    a-hilaly authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2bb9266 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Pin ACK runtime to v0.31.0 (#514)

    Pin ACK runtime to v0.31.0. Mainly addressing two github issues:
    - Healthz, liveness and readiness probes aws-controllers-k8s/community#2012
    - CARM Race condition and scaling issues aws-controllers-k8s/community#2011
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    a-hilaly authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c2165b6 View commit details
    Browse the repository at this point in the history
Loading