Fix evaluator and reporter defects where a rule reported compliance, or nothing at all, for input it should have rejected - #717

Merged

Zee2413 merged 61 commits into

aws-cloudformation:mainfrom

awsmadi:pr/negation-and-reporting-fixes

Aug 21, 2026

Commits on Aug 11, 2026

Fix usize underflow when a violation is reported on line 0 or 1
awsmadi
committed
2b215cc
Apply clause-level negation to binary comparisons
awsmadi
committed
a54e4ca
Do not let a negated reference to a SKIPped rule report compliance
awsmadi
committed
ed342ea

Commits on Aug 17, 2026

Give a definite verdict when a comparison's reference resolves empty
awsmadi
committed
d0eb7c3
Replace the strictness booleans with a ClauseRole type
awsmadi
committed
85ac1d8
Apply clause-level negation to parameterized rule calls
awsmadi
committed
84d306e
Apply rustfmt
awsmadi
committed
a00192c
Make EMPTY on a boolean an incompatible type, and keep a SKIPping parameterized gate SKIP
awsmadi
committed
ff7205d
Fail closed when a comparison's reference resolves to no values
awsmadi
committed
f0ad30c
Pin the fail-closed semantics, and document the behavior change
awsmadi
committed
9a9dbb6
Reword a doc comment so the spell checker stops rejecting it
awsmadi
committed
430c38a
Anchor test path sanitisation on the crate dir, not $HOME
awsmadi
committed
b6d384d
Require callers of eval_when_condition_block to name the clause role
awsmadi
committed
70b9006
Render the explanations the reporters were discarding
awsmadi
committed
de431f7
Compare integers against floats numerically
awsmadi
committed
70feb75
Pin the comparison and type-block behaviour a coverage sweep left unasserted
awsmadi
committed
7ea5c43
Pin the unary operators across every value shape
awsmadi
committed
a023d09

Commits on Aug 18, 2026

Evaluate a type block's conditions against each resource
awsmadi
committed
eeddc92
Let a skipped rule explain why it did not apply
awsmadi
committed
ca818b0
Narrow the map key filter comparator to what the parser can produce
awsmadi
committed
b104090
Assert the status decisions nothing in the suite reached
awsmadi
committed
cc5a2f5
Document the type block, and that integers compare against floats
awsmadi
committed
d56965c
Say when a rule did not apply because a condition was undecidable
awsmadi
committed
f3c919f
Stop the disjunction context depending on the compiler version
awsmadi
committed
46156f0
Stop applying an index twice after an interpolated map key
awsmadi
committed
9900d0b
Truncate a long IN comparison in the failure message
awsmadi
committed
dcf52ad
Skip an unresolvable type block query instead of aborting the rules file
awsmadi
committed
e814a88
Report failing rules in a fixed order
awsmadi
committed
07bcd4f
Fix a blank violation snippet and a panic on an out-of-range index
awsmadi
committed
7cefd51
Correct three diagnostics this branch got wrong
awsmadi
committed
6048e90
Generate rule shapes and assert the invariants that need no oracle
awsmadi
committed
1f0d82c
Sort the compliant section, and fix two comments that inverted their own code
awsmadi
committed
4440040
Correct a determinism comment that claimed its own fix had not worked
awsmadi
committed
7268688
Decide range membership across integer and float
awsmadi
committed
83276df
Make Hash and Eq consistent on PathAwareValue
awsmadi
committed
69e41ea
Render two explanations that were recorded and then dropped
awsmadi
committed
b6c4d22
Stop an unanswerable clause from discarding the whole rules file
awsmadi
committed
b116f48

Commits on Aug 19, 2026

Fail a rule closed when its gate cannot be evaluated
awsmadi
committed
4c8c650
Make a range equal to itself, and keep junit skip reasons apart
awsmadi
committed
b5153de
Make an array index name one element or none
awsmadi
committed
3417a81
Fail closed on membership and on an empty left-hand side, and add an oracle
awsmadi
committed
30237d8
Revert the membership fail-closed change: it breaks five registry rules
awsmadi
committed
9a9600d
Warn a release ahead for two clauses whose answer changes
awsmadi
committed
60da014
Split the oracle's known disagreements by what they contradict
awsmadi
committed
2b53c97
Give the oracle a third answer for an empty collection
awsmadi
committed
d4fea74
Print the same test report twice for the same input
awsmadi
committed
d9de29c
Show the deprecation notices to the people who write the rules
awsmadi
committed
78f1f11
Say when a test expectation matched no rule
awsmadi
committed
90066da
Stop citing commit hashes that rebasing has already invalidated
awsmadi
committed
efeed83
Stop announcing an ordinary rule as a parameterized one
awsmadi
committed
99ffeff

Commits on Aug 20, 2026