Skip to content

udpate docker run to force platform to linux/amd64 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/rpdk/python/codegen.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ def _docker_build(cls, external_path):
stream=True,
entrypoint="",
user=localuser,
platform="linux/amd64",
)
except RequestsConnectionError as e:
# it seems quite hard to reliably extract the cause from
Expand Down
5 changes: 5 additions & 0 deletions tests/plugin/codegen_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,7 @@ def test__build_docker_posix(plugin):
stream=True,
entrypoint="",
user=ANY,
platform="linux/amd64",
)


Expand All @@ -652,6 +653,7 @@ def test__build_docker_windows(plugin):
stream=True,
entrypoint="",
user="root:root",
platform="linux/amd64",
)


Expand Down Expand Up @@ -681,6 +683,7 @@ def test__build_docker_no_euid(plugin):
stream=True,
entrypoint="",
user="root:root",
platform="linux/amd64",
)


Expand All @@ -701,6 +704,7 @@ def test__docker_build_good_path(plugin, tmp_path):
stream=True,
entrypoint="",
user=ANY,
platform="linux/amd64",
)


Expand Down Expand Up @@ -743,4 +747,5 @@ def test__docker_build_bad_path(plugin, tmp_path, exception):
stream=True,
entrypoint="",
user=ANY,
platform="linux/amd64",
)