Skip to content

Validate if subnet CIDRs are valid or overlap #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 4, 2025

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Mar 3, 2025

Issue #, if available:

Description of changes:

  • Add rule E3059 to validate if subnet CIDRs are within the VPC networks
  • Add rule E3060 to validate if subnet CIDRs do not overlap with eachother

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 96.83544% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.88%. Comparing base (85e1576) to head (a4f32a2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/rules/resources/ectwo/VpcSubnetCidr.py 96.62% 1 Missing and 2 partials ⚠️
.../cfnlint/rules/resources/ectwo/VpcSubnetOverlap.py 97.10% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3985      +/-   ##
==========================================
+ Coverage   93.85%   93.88%   +0.02%     
==========================================
  Files         373      375       +2     
  Lines       12817    12975     +158     
  Branches     2502     2550      +48     
==========================================
+ Hits        12030    12182     +152     
- Misses        436      438       +2     
- Partials      351      355       +4     
Flag Coverage Δ
unittests 93.87% <96.83%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the rule/new/E3059 branch 3 times, most recently from 660dd2f to d016bdb Compare March 3, 2025 21:48
@kddejong kddejong merged commit c7595a6 into aws-cloudformation:main Mar 4, 2025
21 checks passed
@kddejong kddejong deleted the rule/new/E3059 branch March 4, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant