Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert schema to make Tag, Subscription and TopicName to be backwards… #55

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

shih
Copy link
Contributor

@shih shih commented Aug 17, 2022

… compatible, also change wait time for addSubscription

Issue #, if available:
We had a few tickets during Uluru rollout that pattern in Tags, or enum in Subscriptions are preventing customers from creating new resource. Root cause is that the new aws-sns-topic.json in Uluru adds more restrictions on properties, and not backwards compatible.
Description of changes:

  1. Compare current schema with non Uluru schema: https://schema.cloudformation.us-east-1.amazonaws.com/aws-sns-topic.json
    1. Remove pattern and length check for Tags.
    2. Change uniqueItems for Subscriptions and Tags from true to false
    3. Remove min and max length for TopicName
    4. Keep "insertionOrder": false, for Tags and Subscription
    5. For primaryIdentifier, from previous CR, it should be the same behavior in Native and Uluru, so I am keeping this change.
  2. Make accordingly change to Translator to translate Tags and Subscriptions from List, instead of Set.
  3. For Contract Test, change the way of wait to:
    • Wait 6 seconds after creating a new topic (Verified in IAD, PDX, FRA and DUB, in most cases 5 seconds can pass, but not stable enough)
    • If it is creating stack, the expected list subscription by topic result count should equal to request subscription size.
      • If not, then wait for 2 seconds and list subscriptions by topic and compare size again
      • Max retries is 10 times.
      • Have verified the test test_read_input_output_negative_match in IAD, PDX, FRA and DUB

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

… compatible, also change wait time for addSubscription
@shih shih requested review from WillSun214 and mangeche August 17, 2022 13:12
@shih shih marked this pull request as ready for review August 17, 2022 13:20
@shih shih merged commit 6567ae9 into aws-cloudformation:master Aug 17, 2022
@shih shih deleted the fix_schema branch August 17, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants