Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve duplicate topic tags #45

Merged
merged 1 commit into from
Jan 26, 2021
Merged

resolve duplicate topic tags #45

merged 1 commit into from
Jan 26, 2021

Conversation

yangmarc
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR resolves the duplicate tags if same tags with different value. Previously, it will cause failure.

The resolve rule is that last tag wins.

Tested with:

{
    "Resources": {
        "MyTopic": {
            "Type": "AWS::SNS::Topic",
            "Properties": {
                "Tags": [
                    {
                        "Key" : "keyname",
                        "Value" : "value1"
                    },
                    {
                        "Key" : "keyname",
                        "Value" : "value2"
                    }
                ]
            }
        }
    }
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yangmarc yangmarc requested review from amz-ansun and weifch January 26, 2021 19:08
@yangmarc yangmarc merged commit be79bf9 into master Jan 26, 2021
@yangmarc yangmarc deleted the duplicate_tags branch January 26, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants