Issue #63: Use aws_signature for signing of requests rather than aws-erlang's own implementation #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onno-vos-dev
commented
Feb 15, 2023
onno-vos-dev
commented
Feb 15, 2023
onno-vos-dev
force-pushed
the
issue-63-use-aws_signature-library-for-signing
branch
from
839ab21
to
3f5c292
Compare
…han aws-erlang's own implementation
onno-vos-dev
force-pushed
the
issue-63-use-aws_signature-library-for-signing
branch
from
3f5c292
to
139af39
Compare
andreashasse
approved these changes
Feb 17, 2023
jadeallenx
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Historically
aws-erlanghas struggled a bit when it came to signature signing resulting in the dreadedSignatureDoesNotMatcherrors which are a massive pain to debug. This meant certain bits ofaws_signaturehad to be backported intoaws-erlang's implementation which is very error prone. Removing all logic for signature signing fromaws-erlangand making use ofaws_signatureinstead closes that long standing issue and ensures that signature signing is unified amongaws-elixirandaws-erlang🎉 🥂I understand that the diff is a mess but that's kinda unavoidable... I'll point out a few areas of interest where I'd like some additional eyes in particular.
I haven't decided whether or not I want to keep
aws_requestaround or move the signing part intoaws-codegen. I believe "most" already sits inaws-codegenso I'll take a look when it's time to address #125 (comment) and #125 (comment) (on my todo list)