Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated findings from Nika #4836

Merged
merged 6 commits into from
Nov 16, 2022
Merged

updated findings from Nika #4836

merged 6 commits into from
Nov 16, 2022

Conversation

abdallahshaban557
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 commented Nov 14, 2022

Issue #, if available:

Updates to docs based on feedback from Nika

Also fixes #4837

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tannerabread
tannerabread previously approved these changes Nov 14, 2022
Copy link
Contributor

@tannerabread tannerabread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one non-blocking suggestion but otherwise LGTM!

…provisionBackend.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
tannerabread
tannerabread previously approved these changes Nov 14, 2022
Copy link
Contributor

@tannerabread tannerabread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚢

Copy link
Contributor

@tannerabread tannerabread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@katiegoines katiegoines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katiegoines katiegoines merged commit ac3edab into main Nov 16, 2022
@katiegoines katiegoines deleted the docs_feedback_from_Nika branch November 16, 2022 22:33
jhockett added a commit that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feedback]Typo on page
3 participants